oat-sa / qti-sdk

A QTI (Question & Test Interoperability) Software Development Kit for PHP
http://www.taotesting.com
GNU General Public License v2.0
82 stars 32 forks source link

Feat/tr 5782/dry run items #373

Closed gabrielfs7 closed 1 year ago

gabrielfs7 commented 1 year ago

https://oat-sa.atlassian.net/browse/TR-5782 https://oat-sa.atlassian.net/browse/RFE-544

Goal

I've needed to create new methods because:

1) I needed to use the behavior of those methods outside and they are protected. 2) I did not want to change the visibility of the current methods (that are protected) as I would have to change all the places inheriting those methods and therefore avoiding breaking changes. 3) I am not sure that their behavior will be the only behavior needed in the future and I would not like to make the existing methods logic (internal) to be affected by this.

Related PRs

gabrielfs7 commented 1 year ago

What the reason in that method they do nothing, why we just not use them directly?

P.S.> Copyright (c) not updated

Thanks @kilatib !

To answer your question, there are 3 reasons I've created new methods.

1) I needed to use the behavior of those methods outside and they are protected. 2) I did not want to change the visibility of the current methods (that are protected) as I would have to change all the places inheriting those methods and therefore avoiding breaking changes. 3) I am not sure that their behavior will be the only behavior needed in the future and I would not like to make the existing methods logic (internal) to be affected by this.