search

oatpp / oatpp-openssl

OpenSSL adaptor for Oat++ applications
https://oatpp.io/
Apache License 2.0
13 stars 22 forks source link

Add option to link with MSVC static runtime (OFF by default) #16

Closed sgallou closed 1 year ago

sgallou commented 1 year ago

Like for oatpp, oatpp-swagger and oatpp-websocket, add option to link with MSVC static runtime (OFF by default)

sgallou commented 1 year ago

I don't understand why some checks failed (not all). OpenSSL seem's to be missing. @lganzzzo , can you check why, please ?

sgallou commented 1 year ago

Seems that MacOS build failed because of OpenSSL dependency not found by CMake. I think that problem is related to the build job, not to my changes.

Detailed error message is "Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY OPENSSL_INCLUDE_DIR) (Required is at least version "1.1")

@lganzzzo Can you check that ?

lganzzzo commented 1 year ago

@sgallou , Yes, it looks like the issue of vcpkg which is used in Mac pipeline. If it continue to occur - I'll remove vcpkg from the Mac pipeline. Rerunning...

sgallou commented 1 year ago

@lganzzzo Same problem again :-(

lganzzzo commented 1 year ago

Merged. Thanks for the PR! I'll update the pipeline...