oatpp / oatpp-openssl

OpenSSL adaptor for Oat++ applications
https://oatpp.io/
Apache License 2.0
13 stars 22 forks source link

Adds buffered configurers #18

Closed fwh-dc closed 1 year ago

fwh-dc commented 1 year ago

Adds private key buffer, certificate buffer and certificate chain buffer configurers

fwh-dc commented 1 year ago

Hi @lganzzzo

Hope you have time for this one as well 🙏

lganzzzo commented 1 year ago

Hello @fwh-dc , Looks good!

Please add a test using buffered certs. - you can just use an existing FullTest Just add an option there so it could be run both with file certs and buffered cets.

Regards, Leonid

fwh-dc commented 1 year ago

Good catch @lganzzzo I've added it now.

lganzzzo commented 1 year ago

Hello @fwh-dc ,

Looks good! Please simplify cert loading as described above and it's ready to merge.

Regards, Leonid

fwh-dc commented 1 year ago

Nice, didn't notice you had the functionality.

lganzzzo commented 1 year ago

Great work! Merged!