search

oatpp / oatpp-swagger

OpenApi 3.0.0 docs + Swagger UI for oatpp services
https://oatpp.io/
Apache License 2.0
94 stars 53 forks source link

Fix: Let oatpp 1.3.0 and its new string implmentation work. #50

Closed grisuthedragon closed 2 years ago

grisuthedragon commented 3 years ago

With version 1.3.0 oatpp uses a string implementation based on std::string. Thus, the string operations on StrBuffer need to be replaced as well.

It uses the oatpp::String::equalsCI function. Please ensure to upgrade oatpp to the latest 1.3.0 version before.

The PR https://github.com/oatpp/oatpp/pull/471 have to be merged before since it brings the equalsCI method in the string class.

lganzzzo commented 3 years ago

Hello @grisuthedragon ,

Please find this PR - https://github.com/oatpp/oatpp/pull/473 (following your PR https://github.com/oatpp/oatpp/pull/471 ) And update this PR accordingly.

Basically, you have to change compareCI to compareCI_ASCII method calls.

grisuthedragon commented 3 years ago

I updated the PR in order to match the new function names.