oats-center / isoblue

ISOBlue Hardware, Avena software, and Deployment Files
MIT License
20 stars 9 forks source link

Kept gps_nats. changed ip to localhost #190

Closed ksoontho closed 2 years ago

ksoontho commented 2 years ago

Brought back gps_nats. Change ip to localhost

ksoontho commented 2 years ago

You might want to change natspy to nats-py in the requirements.txt file. Also, please delete the docker-compose-example.yml and docker-compose-text.yml.unfinished files. They are not necessary.

I created a new commit. LMK if you can see it.

abalmos commented 2 years ago

@ksoontho I think you forgot to add your changes to requirements.txt. I think that is all that is left and I can run the CI which will build the image

ksoontho commented 2 years ago

Fixed.

abalmos commented 2 years ago

It's building now. The CI is a bit dodgy and rebuilds everything. Some of the services take a while. I'll try to keep an eye on it and let you know the results.

abalmos commented 2 years ago

Oh, shoot. We forgot something. I need you to edit this file:

https://github.com/oats-center/isoblue/blob/9975ec7396986064436bc331ad2d4632ef3130b5/.github/workflows/build-and-push-services.yml#L21

And add your new folder to that list

abalmos commented 2 years ago

Here is your service build:

https://github.com/oats-center/isoblue/runs/6032852592?check_suite_focus=true

abalmos commented 2 years ago

Yikes. This is annoying.

Apparently the tag name in docker hub has to lower case and we automatically use the exact service name to create the tag...

I suggest change the folder name from CapstonePython to something like j1939_filter and then update the workflows file.

abalmos commented 2 years ago

https://github.com/oats-center/isoblue/runs/6032943573?check_suite_focus=true

ksoontho commented 2 years ago

wow. by clicking that link am i watching it in real time?

abalmos commented 2 years ago

Good job guys. Merging and it should be up on docker hub in a few minutes.

abalmos commented 2 years ago

https://github.com/oats-center/isoblue/runs/6032982786?check_suite_focus=true

abalmos commented 2 years ago

Here it is on dockerhub:

https://hub.docker.com/r/isoblue/j1939_filter

@facastiblancor what's next?

facastiblancor commented 2 years ago

Only needs testing. Will deploy on dev05 and then later this week to the Skid-steer when available.