search

oats-center / isoblue

ISOBlue Hardware, Avena software, and Deployment Files
MIT License
20 stars 9 forks source link

Add: Hostname prefix on gps_nats messages #209

Closed facastiblancor closed 1 year ago

facastiblancor commented 2 years ago

This PR adds a prefix with the machine hostname to all messages published by this service.

facastiblancor commented 2 years ago

Does the python nats lib expect you to flush?

Yes, that is to ensure that the message has been published.

abalmos commented 2 years ago

Yes, that is to ensure that the message has been published

Sure, it is just an antipattern to call it in the nats.ws and nats-rs library outside of writing tests, so I surprised to see it here. For example: https://github.com/nats-io/nats.ws#flush