oaubert / advene

Official Advene repository
https://www.advene.org/
GNU General Public License v2.0
36 stars 9 forks source link

Importing JSON annotations from previous Advene session isn't working #65

Closed a-darcher closed 3 years ago

a-darcher commented 3 years ago

Hi Advene team,

really like Advene and using it has improved my annotation workflow a ton!

I'm running into an issue on the current version while trying to import JSON files generated in a previous Advene session. When I import the JSON file using the Importer tool, setting the filter to WebAnnotation importer, it cannot successfully import the file and only adds an empty annotation. Is the WebAnnotation filter not the correct one for JSON files, or is there another issue?

Here is a screenshot showing the pop-up message post-importing: Screenshot from 2021-03-22 12-06-29

oaubert commented 3 years ago

Thanks for the report, there were some errors in the webannotation import filter (as well as duplicated WebAnnotation export filters - the old template-based on overriding the newer python-based one). I have just fixed these.

a-darcher commented 3 years ago

I'm trying to re-install advene from the GH source in order to make use of your fixes, but I'm running into some issues with make-ing the executable (namely -- epydoc hasn't been updated for Python 3 and throws errors during the build).

Is there any chance that you are planning to release a new debian binary with the updated changes? Conversely -- is there an obvious way of using advene from GH source that I'm missing? :)

Thanks!

oaubert commented 3 years ago

A new release should occur soon, but I have some unfinished patches to integrate. If you want to run the git version from sources, you can uninstall the Debian package (so that there is no confusion between installed and dev modules) and simply run ./bin/advene from the git tree.

franzigrkn commented 3 years ago

I am trying the same thing and as you suggested, I installed the current git version from source, but unfortunately I still cannot import the json file correctly. I get the same error message as shown above and there is just an empty annotation imported. Just for clarification: I work on Linux and installed all required packages in a Conda env, cloned the git repo and ran ./bin/advene -pdummy. Up to here, everything works fine, but the import fails. Do you have any idea what the reason might be?

I also wondered if there is way of converting the json to a format which can be accepted by advene?

Thanks already in advance!

oaubert commented 3 years ago

Were your json files exported as Flat JSON, or WebAnnotation?

franzigrkn commented 3 years ago

As far as I know it has been exported as Flat JSON.

oaubert commented 3 years ago

OK. Then you can update from the git tree, I added this morning a FlatJSON importer, which is able to re-import data exported using the FlatJSON export format.

franzigrkn commented 3 years ago

That worked! :) Thank you very much for your help, I appreciate it!