oaubert / advene

Official Advene repository
https://www.advene.org/
GNU General Public License v2.0
36 stars 9 forks source link

Nosferatu - v14 - Home #82

Open staphon7 opened 3 years ago

staphon7 commented 3 years ago

Hello there,

My operating system is Arch Linux.

Here is the output of advene --version:

How to reproduce the issue:


Navigation and steps:
We are there: http://localhost:1234/packages/Nosferatu_v14/view/Home.

  1. Chapter: "This hypervideo"

  2. Chapter: "Settings things up"


Nota bene:
I have tested the https://archive.org/download/Nosferatu1922_201811/Nosferatu%201922.ogv file with "Nosferatu_v14.azp".
It matches almost perfectly.

As you know, if you decide to give that file as a link to the movie, you will have to generate the "Scene chance" and "Sound enveloppe" annotation types again.
Then, that if you wish - let me a comment -, I will look for and note what has to be fixed about the other annotation types - there might be some slight things to fix.
For example, in the "Nightmare triangle" annotation type, one of the shots - Nosferatu behind the bars - has to be adapted.
And concerning "nosfe.css", the classes "screenshot", "half_screenshot" and "screenshot_container" might have to be fixed.
Despite that, about "nosfe.css", one of the value "width" or "height" of "screenshot" and "half_screenshot", to respect the aspect-ratio of the image, should be set to "auto" - but this might not be what you want.

All that said, there might be a better idea, for both of us:
How about, after your agreement - comment in the issue - I check and fix the annotation types and then send you a "Nosferatu_v14_fixed.azp", or every exported annotation types files I fixed in "Nosferatu_v14.azp".
You could then import them and check if things are good to you.

This is just a proposition, if you don't want to change anything, it's obviously fine to me.


Thank you

oaubert commented 3 years ago

Hi. Thanks for all the detailed tests and suggestions. Your proposed approach is perfectly fine: fix things in your own copy of Nosferatu_v14 and I will merge them for the next release. Do not hesitate to add comments where you are uncertain.

staphon7 commented 3 years ago

All right, I'll do the thing in my own copy of Nosferatu_v14. In my above comment, I used the verb "to send" but I didn't say how to. Would you like me to send the file by email - to "contact alt advene dot org" - or using a github "PR"?

oaubert commented 3 years ago

Great. Yes, you can send it by e-mail at the indicated address.

staphon7 commented 3 years ago

Hello there,

Thank you

staphon7 commented 3 years ago

Hello there,


Element A


Element B


Element C


Element D


Thank you

oaubert commented 3 years ago

Hi. Thanks for the detailed report. For A, you can extend the last Episode to cover the whole movie. For B, annotations should be realigned. This should be doable by DNDing the reference annotation type on the annotation type to realign, there will be an Alignment menuitem. For the annotation content, let's keep it for the moment, we can discuss about the validity of fear annotation later on. For C, it should be something like "Nosferatu drinking blood" (which, if you find it natural, would indicate that you have some Transsylvanian origin :-) For D, The Sound enveloppe can be regenerated to match the movie.

staphon7 commented 3 years ago

Hello there,

Everything is done but the "Text annotation" annotation type which is empty of annotations. Should I delete it? I'm sorry about that last question, I should have thought about that in my last comment. Right after your answer I'll do a last check and send the file to you.

Thank you