This isn't a necessary or a required change, I did it more out of interest as I had initially implemented my own discord oauth2 passport strategy prior to finding this repo.
cjs output goes to dist/cjs, esm output goes to dist/esm, type output goes into dist and is done independently of the builds via it's own build:types script.
34:31 error Don't use `object` as a type. The `object` type is currently hard to use ([see this issue](https://github.com/microsoft/TypeScript/issues/21732)).
Consider using `Record<string, unknown>` instead, as it allows you to more easily inspect and use the keys @typescript-eslint/ban-types 34:31 error Don't use `object` as a type. The `object` type is currently hard to use ([see this issue](https://github.com/microsoft/TypeScript/issues/21732)).
Consider using `Record<string, unknown>` instead, as it allows you to more easily inspect and use the keys @typescript-eslint/ban-types
34:47 error Don't use `object` as a type. The `object` type is currently hard to use ([see this issue](https://github.com/microsoft/TypeScript/issues/21732)).Consider using `Record<string, unknown>` instead, as it allows you to more easily inspect and use the keys
These lint errors were present, so I replaced all object type uses as recommended.
I've tested these changes using npm pack and installing the local file on a live application with the following configuration:
The DiscordUserProfile type below is my own which extends the included Profile type (covers the identify scope).
This isn't a necessary or a required change, I did it more out of interest as I had initially implemented my own discord oauth2 passport strategy prior to finding this repo.
cjs output goes to
dist/cjs
, esm output goes todist/esm
, type output goes intodist
and is done independently of the builds via it's ownbuild:types
script.These lint errors were present, so I replaced all
object
type uses as recommended.I've tested these changes using
npm pack
and installing the local file on a live application with the following configuration:The DiscordUserProfile type below is my own which extends the included Profile type (covers the identify scope).
Take it or leave it, the changes are here!