oauth-wg / oauth-sd-jwt-vc

draft-terbu-sd-jwt-vc
Creative Commons Zero v1.0 Universal
20 stars 12 forks source link

Define terminology of SD-JWT-VC, etc. #10

Closed awoie closed 1 year ago

awoie commented 1 year ago

I think we need to define what the following "things" are.

I believe it is the JWT that contains the _sds. It is not any of the combined formats. This means that the Verifiable Credential MAY NOT contain any disclosable claims, e.g., name. Would you agree @tlodderstedt, @Sakurann, Daniel?

The VC based on SD-JWT will have the media type application/vc+sd-jwt.

Can we call the Combined Format for Issuance AND Presentation the Presentation based on SD-JWTs, and if there is HB, then it is a Verifiable Presentation?

The VP based SD-JWT will have the media type application/vp+sd-jwt altough I'm not sure if this makes sense. Wouldn't it better to have application/vp+vc+sd-jwt? Any thoughts on that?

awoie commented 1 year ago

Also it is important to note that for OIDC4VP we use Verifiable Presentations in vp_token and we use Verifiable Credentials in OIDC4VCI in the credential response.

It probably has the implication that for OIDC4VCI, we will put the VC based on SD-JWT into the credential response, or we define a format identifier for something else. Keep in mind we need to send the disclosures to the client as well. In that regards is the SD-JWT itself the SD-JWT-VC without disclosures, or is the combined format including disclosures the SD-JWT-VC? Or we follow the approach above and we return a combined presentation (no HB) in the credential response and define a credential identifier for that.

It probably also means that we would put the VP based on SD-JWT into the OIDC4VP vp_token.

tlodderstedt commented 1 year ago

We (IDunion) put the combined presentation (+hb jwt) in the vp_token. What else would you expect?

awoie commented 1 year ago

We (IDunion) put the combined presentation (+hb jwt) in the vp_token. What else would you expect?

That makes sense, so the VP based on SD-JWT is the combined format for presentation including HB JWT.

Then, there is the question what would the OIDC4VCI credential response return? And what would be a format identifier? I know that this doesn't have to be answered in this spec but it helps with answering the terminology question.

Sakurann commented 1 year ago

Suggest we not overcomplicate things and say:

awoie commented 1 year ago

This is potentially fixed by PR #21