search

oauth-wg / oauth-sd-jwt-vc

draft-terbu-sd-jwt-vc
Creative Commons Zero v1.0 Universal
20 stars 12 forks source link

Rename 'type' to 'vct' #174

Closed danielfett closed 1 year ago

danielfett commented 1 year ago

This PR renames the claim type to dct, as per the discussion in #130

tlodderstedt commented 1 year ago

I oppose against this change. I suggest to use 'vct' instead.

selfissued commented 1 year ago

I'm good with vct.

For the record, I think it's important to move away from type, because https://www.w3.org/TR/vc-data-model/ uses the claim name, but with a different syntax. Keeping the naming conflict will inevitably lead to grief.

paulbastian commented 1 year ago

Naming is hard. Regarding dct: isn't it obvious for an internet standard that we refer to digital credentials?

Sakurann commented 1 year ago

Neither dct nor vct are intuitive for me, so I am pretty unsure.

But between dct and vct, I would prefer dct. A term Verifiable credentials got enough feedback that it has strong too strong of an association to W3C VC-DATA-MODEL. And Digital credentials seems to be a term that is acceptable to generalize.

awoie commented 1 year ago

Neither dct nor vct are intuitive for me, so I am pretty unsure.

But between dct and vct, I would prefer dct. A term Verifiable credentials got enough feedback that it has strong too strong of an association to W3C VC-DATA-MODEL. And Digital credentials seems to be a term that is acceptable to generalize.

Why is "Verifiable Credential Type" (vct) not intuitive to you? This would match the current definition of type. Isn't this what this claim is about? That is why I'm actually in favor of vct over dct, dty.

Sakurann commented 1 year ago

I meant that abbreviations are not intuitive to me.

And "type" is a pretty JSON-LD specific construct AFAIK so I was hoping we could have a deeper discussion on whether it should be called "claimset" or something. If we are to move away from "type" claim name.

on dct and vct, as I explained, I prefer something that is not associated to W3C VCDM and digital credentials seems to be pretty well understood.

bc-pi commented 1 year ago

If the color of the bikeshed is still open for debate, how about just ct for credential type?

awoie commented 1 year ago

If the color of the bikeshed is still open for debate, how about just ct for credential type?

I like 3-letter-names more than 2-letter-names for some reason. Also, vct is more accurate since the spec is about SD-JWT VCs => Verifiable Credentials. I'd be still in favor of vct for that reason.

danielfett commented 1 year ago

vct is fine for me. Updated the PR accordingly.

bc-pi commented 1 year ago

vct is fine for me too. ct was just an off-hand idea

awoie commented 1 year ago

Merging this PR since a lot of approvals. We will have a larger conversation on what is inferred by the vct value in a separate issue.