oauth-wg / oauth-sd-jwt-vc

draft-terbu-sd-jwt-vc
Creative Commons Zero v1.0 Universal
20 stars 12 forks source link

use SD-JWT+KB in place of SD-JWT with a Key Binding JWT #243

Open bc-pi opened 4 months ago

bc-pi commented 4 months ago

As of SD-JWT -09 which "Distinguished SD-JWT from SD-JWT+KB" the phrase "SD-JWT with a Key Binding JWT" may/should be replaced with "SD-JWT+KB"

selfissued commented 4 months ago

I disagree with this, as this textual substitution would make the meaning of the specification less clear. "SD-JWT with a Key Binding JWT" is an accurate, self-evident description, whereas "SD-JWT+KB" is opaque (at best). It's not like having an optional key binding be present makes the SD-JWT any less of an SD-JWT, just like having a "cnf" claim present doesn't make a JWT any less a JWT. In both cases, they are simply utilizing an optional feature, and should continue to be described that way.

bc-pi commented 3 months ago

This issue was mostly a note/todo to reconcile terminology usage here with the contributions @bifurcation made to the underlying core SD-JWT document, which were iterated on for over six months before being incorporated https://github.com/oauth-wg/oauth-selective-disclosure-jwt/pull/394

But I honestly don't care enough about this one to push either way and would happily close, if the other editors are okay with it.

danielfett commented 1 month ago

At a minimum we should use the term "SD-JWT+KB" somewhere so that it is clear what we're talking about.