search

oauth-wg / oauth-selective-disclosure-jwt

https://datatracker.ietf.org/doc/draft-ietf-oauth-selective-disclosure-jwt/
Other
56 stars 31 forks source link

use the term Key Binding rather than Holder Binding #286

Closed bc-pi closed 1 year ago

bc-pi commented 1 year ago

Change to use Key Binding and Key Binding JWT rather than Holder Binding and Holder Binding JWT.

for issue #281

bc-pi commented 1 year ago

Did some more work on this based on discussions yesterday and I believe it's now ready for review @Sakurann and @danielfett

bc-pi commented 1 year ago

Editor's copy for this branch: https://drafts.oauth.net/oauth-selective-disclosure-jwt/bc/key-rather-than-holder/draft-ietf-oauth-selective-disclosure-jwt.html

bc-pi commented 1 year ago

I realized/noticed that there were still things like holder_binding in yaml and hb_ in file names. So I changed holder_binding to key_binding and hb_ to kb_ and holder binding to key binding throughout the sd-jwt lib to try and have code, comments, and generated files reflect calling it key binding rather than holder binding. And made the corresponding changes here. Including changes to .github/workflows/ghpages.yml which needs to be undone around merge time and doesn't feel right but not sure how else to do it.