oauth-wg / oauth-selective-disclosure-jwt

https://datatracker.ietf.org/doc/draft-ietf-oauth-selective-disclosure-jwt/
Other
56 stars 29 forks source link

two dots as &#168 display issue #299

Closed bc-pi closed 1 year ago

bc-pi commented 1 year ago

"it shows as two dots ¨ placed over the letter is there any way to change that..? (this is not the change introduced in this PR)" on the text in the doc at https://www.ietf.org/archive/id/draft-ietf-oauth-selective-disclosure-jwt-04.html#section-5.1.1.1-9.1 "A different way to encode the umlaut (two dots ¨ placed over the letter):"

_Originally posted by @Sakurann in https://github.com/oauth-wg/oauth-selective-disclosure-jwt/pull/293#discussion_r1234687656_

danielfett commented 1 year ago

Not sure why this broke now. I created a PR because the example wasn't ideal anyway: https://github.com/oauth-wg/oauth-selective-disclosure-jwt/pull/300

danielfett commented 1 year ago

I just noticed that the PR does not fully solve the problem. We have the same problem somewhere else as well:

Screenshot_20230620_211135

bc-pi commented 1 year ago

it's seems to have been an issue at least back to -01 https://www.ietf.org/archive/id/draft-ietf-oauth-selective-disclosure-jwt-01.html#section-5.1-9 and/or -02 https://www.ietf.org/archive/id/draft-ietf-oauth-selective-disclosure-jwt-02.html#section-5.2.1.1-9.1 (so basically since inception).

I'm sure we could fight with the tool chain to fix it. But at what cost? I'm inclined to just reword that "The two representations... " part to make the issue go away. Which I did with this 48efde35a81ca3520eb30ceea6c43d62e8cd96f8 update to https://github.com/oauth-wg/oauth-selective-disclosure-jwt/pull/300

Sakurann commented 1 year ago

PR merged