oauth-wg / oauth-selective-disclosure-jwt

https://datatracker.ietf.org/doc/draft-ietf-oauth-selective-disclosure-jwt/
Other
56 stars 29 forks source link

Fix Enveloping section title and remove recommended claim name #302

Closed bc-pi closed 1 year ago

bc-pi commented 1 year ago

I noticed that the consolidation of SD-JWT terminology in c6a27373dee13cc7c3f70a8b7fd374e62306f5a0 introduced a mistake in the "Enveloping" section title by including the word "Presentation" while the section talks about enveloping either issued or presented SD-JWTs. While fixing that, I decided to remove the SHOULD recommending the use of an unregistered claim name _sd_jwt. I also tried to align the example enveloping payload a bit with a move minimal set of claims similar to those used in key binding.

I realize I probably should have just fixed the section title and not expanded the scope of the changes. But there I was and these few little changes were so inviting...

See it here: https://drafts.oauth.net/oauth-selective-disclosure-jwt/enveloping-sec-fixup/draft-ietf-oauth-selective-disclosure-jwt.html#section-7