oauth-wg / oauth-selective-disclosure-jwt

https://datatracker.ietf.org/doc/draft-ietf-oauth-selective-disclosure-jwt/
Other
55 stars 27 forks source link

Improve structure of specification #347

Closed danielfett closed 9 months ago

danielfett commented 9 months ago

To fix Issue #290, this PR reorganizes what was previously section 5 as follows:

Screenshot_20231004_144710

danielfett commented 9 months ago

Note: I also changed the story in Section 5 from a bottom-up to a top-down approach (structure of compact serialization SD-JWT first, then going into the details).

Sakurann commented 9 months ago

The Decoy Digests, Hash Function Claim, Holder Public Key Claim subsections feel a bit out of place in section 7. What would you think about moving them to subsections under 5.1. Issuer-signed JWT Payload?

+1 to this

danielfett commented 9 months ago

I made the additional changes proposed by Brian, with the following deltas:

Editor's copy link: https://drafts.oauth.net/oauth-selective-disclosure-jwt/danielfett/fix-290-new-structure/draft-ietf-oauth-selective-disclosure-jwt.html

bc-pi commented 9 months ago

I moved the section "Decoy Digests" to be the last subsection of "5.2 Disclosures". It did not make sense in 5.1 as not all concepts were introduced there yet.

That makes sense and is better than what I'd suggested.