oauth-wg / oauth-selective-disclosure-jwt

https://datatracker.ietf.org/doc/draft-ietf-oauth-selective-disclosure-jwt/
Other
56 stars 27 forks source link

typ:example+sd-jwt everywhere? #365

Closed bc-pi closed 5 months ago

bc-pi commented 8 months ago

Do we want the header "typ":"example+sd-jwt" in every example? I'm honestly not sure but wanted to ask b/c that looks like it's going to be the result from https://github.com/openwallet-foundation-labs/sd-jwt-python/pull/10 upstream.

danielfett commented 8 months ago

We should make a conscious decision about this, especially regarding the examples in the appendix.

Sakurann commented 7 months ago

for example 4a, it must be vc+sd-jwt because it is required by sd-jwt vc spec here. For example 4b, it should be vc+ld+json+sd-jwt, but it can also be kept example+sd-jwt. because W3C vc-jose-cose spec says The typ header parameter SHOULD be vc+ld+json+sd-jwt..

bc-pi commented 5 months ago

good with the state of things currently for typ values