search

oauth-wg / oauth-selective-disclosure-jwt

https://datatracker.ietf.org/doc/draft-ietf-oauth-selective-disclosure-jwt/
Other
54 stars 27 forks source link

Items from Jeffrey Yasskin's review #397

Closed bc-pi closed 5 months ago

bc-pi commented 6 months ago

which can be found at #389

Sakurann commented 6 months ago

I think the following change might be cleaner per "Check that the Key Binding JWT is valid in all other respects" should call a particular algorithm from the other specs that it cites. in Jefferey's review.

"9. Check that the Key Binding JWT is valid in all other respects, per [@!RFC7519] and [@!RFC8725]." -> "9. Check that the Key Binding JWT is a valid JWT in all other respects, per [@!RFC7519] and [@!RFC8725]."

bc-pi commented 6 months ago

I think the following change might be cleaner per "Check that the Key Binding JWT is valid in all other respects" should call a particular algorithm from the other specs that it cites. in Jefferey's review.

"9. Check that the Key Binding JWT is valid in all other respects, per [@!RFC7519] and [@!RFC8725]." -> "9. Check that the Key Binding JWT is a valid JWT in all other respects, per [@!RFC7519] and [@!RFC8725]."

Sure, that's done in 4442c3a06767498ee24154024d8dff987325b08f