search

oauth-wg / oauth-selective-disclosure-jwt

https://datatracker.ietf.org/doc/draft-ietf-oauth-selective-disclosure-jwt/
Other
57 stars 31 forks source link

Addressing one more of Mike's previous review comments #466

Closed bc-pi closed 2 months ago

bc-pi commented 2 months ago

https://mailarchive.ietf.org/arch/msg/oauth/W88oMIu_no3KYsU60MTmBsuSIJI/ and I don't know why my response isn't on the mail archive yet but here's a copy:

Screenshot 2024-09-19 at 2 43 48 PM

bc-pi commented 2 months ago

oh hey that's fun:

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

bc-pi commented 2 months ago

oh hey that's fun:

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

sadness addressed in 9b7ad2d010e0f49e3dd8b5833c59fe4642e2892b (on the surface anyway)

Sakurann commented 2 months ago

isn't part of this duplicate of #471 ?

bc-pi commented 2 months ago

isn't part of this duplicate of #471 ?

Yeah, I did it here first just to fix things. Then decided fixing the build process should be decoupled from addressing one more of Mike's previous review comments.

bc-pi commented 2 months ago

isn't part of this duplicate of #471 ?

Yeah, I did it here first just to fix things. Then decided fixing the build process should be decoupled from addressing one more of Mike's previous review comments.

Now overcome by events.