search

oauth2-proxy / manifests

For hosting manifests to allow for the deployment of OAuth2-Proxy/OAuth2-Proxy
Apache License 2.0
170 stars 153 forks source link

Set https port to 4443 #117

Closed Palollo closed 1 year ago

Palollo commented 2 years ago

Default port for https was 443 (ref) but it is not allowed for binding by a non-root user. This is what occurs in the default image of this helm chart, so this is a fix for an error appeared when the value "httpScheme" is set to "https".

desaintmartin commented 2 years ago

Indeed. It is similar to https://github.com/oauth2-proxy/manifests/pull/117 but takes a more pragmatic approach. I 117 does not progress in a few days, let's merge this one.

Palollo commented 2 years ago

Indeed. It is similar to #117 but takes a more pragmatic approach. I 117 does not progress in a few days, let's merge this one.

I think you mean #89. I doubt that PR will work well: changing the container port is not enought for that he wants to. He forgot to change the app port in the "args" of the container (params "--http-address" and "--https-address") in deployment.yaml

If he is interested yet, he will see the mention here. I can add suggesting changes for clarification in his PR or include his changes in my PR with the needed additions.

Could you bump version in chart.yaml?

Sure, it's done ;)

desaintmartin commented 1 year ago

Let's merge this, it's easy to rebase in #89 when needed to make it configurable.