search

oauth2-proxy / manifests

For hosting manifests to allow for the deployment of OAuth2-Proxy/OAuth2-Proxy
Apache License 2.0
170 stars 153 forks source link

extraArgs as a list #124

Closed adlnc closed 1 year ago

adlnc commented 1 year ago

Hi,

May I suggest this implement in order to give the ability to supply multiple extraArgs. Tested locally, doesn't seem to break compatibility.

e.g. user can chose between: 

extraArgs:
  pass-authorization-header: "true"
  request-logging: "true"
  allowed-role: client_id:client_role

OR:

extraArgs:
  - --pass-authorization-header="true"
  - --request-logging="true"
  - --allowed-role=client_id:client_role_A
  - --allowed-role=client_id:client_role_B

Solves #101

Any thoughts ?

pierluigilenoci commented 1 year ago

@desaintmartin could you please take a look?

desaintmartin commented 1 year ago

Looks good. In order not to break this in the future, would you add a test values.yaml in the ci/ directory testing? Also, you'll need to rebase to fix test error + bumb minor version of Chart.yaml.

pierluigilenoci commented 1 year ago

@adlnc can you integrate the requested changes and add a bump to the chart version?

pierluigilenoci commented 1 year ago

@adlnc I bumped the chart version for you, could you please integrate the test as requested?

adlnc commented 1 year ago

Added the tests.

Unsure about the rebase asked for fixing test error...

Thanks