Closed jkroepke closed 1 year ago
@jkroepke I'm sorry if I haven't been kind... I forgot to thank you for your contribution. š So thank you! š ā¤ļø
@desaintmartin could you please take a look?
@desaintmartin Tests added!
I agree about helmfile works better in that scenario, but looking forward to GitOps ArgoCD or flux, helmfile does not fit here anymore.
Hehe, the config file actually needs to be valid for the test to pass.
@desaintmartin At least the tests covers only, if the tpl function is working..
This created problems with boolean values: https://github.com/oauth2-proxy/manifests/issues/133
I will setup a pr in for fix this
This PR enabled passing configuration through the helm templating engine again.
Use cases: We have a umbrella helm charts which bundles all helm charts together in one release. Using the pattern, we are able to establish a single configuration plane for multiple components.
In this case, we would like to share some configuration between oauth2-proxy and dex idp. For example dexidp and oauth-proxy shares the same issuer config, client id, client secret.
oauth2-proxy also shares some configuration with grafana, e.g. ingress hostname.
The grafana and kube-prometheus-stack already allows use similar configurations.
Giving an example for values files