search

oauth2-proxy / manifests

For hosting manifests to allow for the deployment of OAuth2-Proxy/OAuth2-Proxy
Apache License 2.0
170 stars 153 forks source link

Can we have the revisionHistoryLimit as a configurable value of the helm chart? #136

Closed ghost closed 1 year ago

ghost commented 1 year ago

Expected Behavior

We should be able to set the revisionHistoryLimit in our values file for a helm deployment of oauth2-proxy

image

Current Behavior

There is no value for setting the revision history limit in the value file

Possible Solution

Allow setting the revisionHistoryLimitValue in the values file and if not specified use the default I think something like this would work in the deployment.yaml file of the helm chart

{{- if .Values.revisionHistoryLimit}}
  revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
{{- end }}

image

Context

Its important to be able to control how many old Replica Sets are maintained.

JoelSpeed commented 1 year ago

I've transferred this to the manifests repo since it has separate owners