search

oauth2-proxy / manifests

For hosting manifests to allow for the deployment of OAuth2-Proxy/OAuth2-Proxy
Apache License 2.0
170 stars 153 forks source link

Add a reference to "config.existingSecret" to Helm Chart default values file #149

Closed guilhem-sante closed 1 year ago

guilhem-sante commented 1 year ago

Describe the solution you'd like Add a reference to the "config.existingSecret" with a small description comment to the Helm chart default values.

What is the added value? It would be more explicit to new users. I've myself discovered the possibility of using an existing secret by reading the _helpers.tpl template file (in v6.12.0).

pierluigilenoci commented 1 year ago

Is this not enough? https://github.com/oauth2-proxy/manifests/blob/main/helm/oauth2-proxy/README.md?plain=1#L101

guilhem-sante commented 1 year ago

You're right ! It seems like I've missed the line I was looking for. Sorry for the bothering.