search

oauth2-proxy / manifests

For hosting manifests to allow for the deployment of OAuth2-Proxy/OAuth2-Proxy
Apache License 2.0
170 stars 153 forks source link

Fixed the case for serviceMonitor values section #171

Closed pierluigilenoci closed 12 months ago

ldunkum commented 12 months ago

Nice PR, but shouldn't this be marked as a breaking change? It can be seen in the parallel PR #170 that this needs some changes to code and also in all deployments that change the values.

pierluigilenoci commented 12 months ago

@ldunkum, you're absolutely right; I realized it too late. I'm very sorry about that. 😢 I have a PR in the works, and I will do a minor on that one in hopes that people will upgrade to that, and nothing will break.