search

oauth2-proxy / manifests

For hosting manifests to allow for the deployment of OAuth2-Proxy/OAuth2-Proxy
Apache License 2.0
170 stars 153 forks source link

Allow configuring terminationGracePeriodSeconds and lifecycle hooks #174

Closed karel1980 closed 11 months ago

karel1980 commented 11 months ago

Please accept my humble PR. These changes would help with zero downtime deployments on EKS.

For sources, please see these issues: https://github.com/kubernetes-sigs/aws-load-balancer-controller/issues/2366 https://github.com/kubernetes-sigs/aws-load-balancer-controller/issues/1064

pierluigilenoci commented 11 months ago

@karel1980 Thank you for your contribution.

The PR needs a bump of the Chart version and an annotation for aAtifactHub to be approved.

karel1980 commented 11 months ago

Will do. Thanks for the quick feedback.

karel1980 commented 11 months ago

@pierluigilenoci I've made the requested changes. I'm not familiar with artifacthub.io, I'm guessing the fix from the 6.19.1 release needed to be removed. If not, let me know I'll add it back in a jiffy

pierluigilenoci commented 11 months ago

@karel1980 Thank you for your contribution!