search

oauth2-proxy / manifests

For hosting manifests to allow for the deployment of OAuth2-Proxy/OAuth2-Proxy
Apache License 2.0
170 stars 153 forks source link

fix: Allow setting revisionHistoryLimit to 0 #183

Closed Farfaday closed 8 months ago

Farfaday commented 9 months ago

Hi,

when revisionHistoryLimit is set to 0, the if condition goes to false and the revisionHistoryLimit is not rendered.

As revisionHistoryLimit has a default value in values.yaml, we can remove the if condition from deployment.yaml

0 is a valid value for revisionHistoryLimit as per: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#clean-up-policy

Many thanks!