oauth2-proxy / manifests

For hosting manifests to allow for the deployment of OAuth2-Proxy/OAuth2-Proxy
Apache License 2.0
170 stars 153 forks source link

add autoscaling #208

Closed sja closed 5 months ago

pierluigilenoci commented 5 months ago

@sja, please add a helm chart bump and edit the artifacthub.io/changes section.

sja commented 5 months ago

Thanks @pierluigilenoci for that info. I did a minor version bump, as it adds a feature. It is backwards compatible, old values do not change the result.

sja commented 5 months ago

@pierluigilenoci I updated the MR again, inspired from the other MRs. Feel free to reach out to me, especially if you want me to modify the version numbers to not have a conflict. Usually, I react in 1 business day.

pierluigilenoci commented 5 months ago

Can the test case with autoscaling enabled in the chart test suite be included? Something like this https://github.com/oauth2-proxy/manifests/blob/main/helm/oauth2-proxy/ci/pdb-values.yaml

sja commented 5 months ago

I added that, but I'm not familar with how to validate the result. Are the results compared to an expected value somewhere or is that more like a smoke test if the values can be rendered at all?

pierluigilenoci commented 5 months ago

@sja Usually, the test results are visible in the pipeline. In this case, they are not, and I don't understand why. However, from the point of view of the feature, this PR is OK like this.

pierluigilenoci commented 5 months ago

@sja ok, fixed https://github.com/oauth2-proxy/manifests/pull/211 🚀

pierluigilenoci commented 4 months ago

@sja Thank you.