oauth2-proxy / manifests

For hosting manifests to allow for the deployment of OAuth2-Proxy/OAuth2-Proxy
Apache License 2.0
170 stars 153 forks source link

Redis Standalone default redis password is set on two different locations #225

Closed JcGKitten closed 2 months ago

JcGKitten commented 3 months ago

After spending some time to figure that out, I wanted to ask if this is intended or a bug.

When using Redis with clientType.standalone configure redis via values like suggested in this comment:

redis:
  enabled: true
sessionStorage:
  type: redis
  redis:
    password: "XXXXXXX"

isn't working and shows the following logs in the oauth pod:

  unable to set a redis initialization key: WRONGPASS invalid username-password pair or user is disabled.
  unable to delete the redis initialization key: WRONGPASS invalid username-password pair or user is disabled.

I discovered in the redis-standalone-values.yaml that the password for redis is also set under redis.global.redis.password. After setting this password:

redis:
  enabled: true
  global:
    redis:
      password: "XXXXXXX"
sessionStorage:
  type: redis
  redis:
    password: "XXXXXXX"

Oauth Proxy can connect to redis and the storage works. So I was wondering if this should be mentioned in the README or if this a bug.

pierluigilenoci commented 2 months ago

@JcGKitten This is because the password must be set in this chart and inside the Redis sub-charts. There is no way to do otherwise. Is it more clear?

Ref:

JcGKitten commented 2 months ago

@pierluigilenoci yes it's more clear now, thx. Hope this issue might help others come across this, but closing it now, cause all needed information is given.