search

oauth2-proxy / oauth2-proxy

A reverse proxy that provides authentication with Google, Azure, OpenID Connect and many more identity providers.
https://oauth2-proxy.github.io/oauth2-proxy
MIT License
9.37k stars 1.54k forks source link

Feature Request: Batteries included dark theme #1643

Closed nepeat closed 4 months ago

nepeat commented 2 years ago

Expected Behavior

A CLI flag to use a bundled dark theme with OAuth 2 Proxy. It would potentially look like --theme=dark

Current Behavior

Possible Solution

Having a batteries-included approach for light/dark themes like any other application. Having the ability to use the differing theme as a new command line argument compared to the current approach would be a plus.

Steps to Reproduce (for bugs)

  1. Attempt to use dark theme for OAuth2 Proxy

Context

As a user, I use a dark theme to match the themes of my other applications and middlewares. My identity provider uses a dark theme by default. My endpoints use dark themes by default. OAuth2 Proxy is the outlier where its default theme is a light theme.

Your Environment

All browsers impacted Firefox + Chrome + Safari. Latest revision of OAuth2-Proxy.

hevans-dglcom commented 2 years ago

Hello,

If you could provide to me the CSS for a dark theme - I will implement it.

JoelSpeed commented 2 years ago

As we are trying to minimise the options and flags at the moment as we try to make this project simpler to maintain and use, i'm hesitant to add new flags for features that can easily be implemented using existing flags. I'm not against keeping a dark theme available in the repo that users can copy, but I'd say the defacto way to do this is to provide the custom templates dir as you are doing already today

github-actions[bot] commented 2 years ago

This issue has been inactive for 60 days. If the issue is still relevant please comment to re-activate the issue. If no action is taken within 7 days, the issue will be marked closed.

bakito commented 1 year ago

Here would be some nice dark theme css: https://jenil.github.io/bulmaswatch/

JoelSpeed commented 11 months ago

How difficult is it to switch the existing CSS over to this version? Could this be something we document for users rather than building it directly into the project?

zs-dima commented 8 months ago

Keen to see a theme setting. Could be nice to reopen this issue.

kvanzuijlen commented 8 months ago

If this is something we want to include I think we should wait for bulma.io v1, which should be coming soon. @JoelSpeed any opinions? I think integrating it shouldn't be too hard.

JoelSpeed commented 8 months ago

I'm happy to include it, though we should make sure it's only in the new config rather than adding yet another flag to the old config style

github-actions[bot] commented 6 months ago

This issue has been inactive for 60 days. If the issue is still relevant please comment to re-activate the issue. If no action is taken within 7 days, the issue will be marked closed.

zs-dima commented 6 months ago

+1 re-activate the issue

github-actions[bot] commented 4 months ago

This issue has been inactive for 60 days. If the issue is still relevant please comment to re-activate the issue. If no action is taken within 7 days, the issue will be marked closed.