oauthjs / express-oauth-server

Complete, compliant and well tested module for implementing an OAuth2 Server/Provider with express in node.js
MIT License
484 stars 384 forks source link

Can someone either document or clarify the use case difference between client.id and client.clientId #129

Closed ronbarbosa closed 3 years ago

ronbarbosa commented 3 years ago

There are situations where the code uses and expects to find client.id and then other areas where it uses client.clientId. Then there are areas (like during the exchange of authorization codes for access tokens) where client.id (from the authorization code) is compared to client.clientId (from the client's database record) for equality.

This seems like the duplication of data under a different node of the object. Please clarify.