Fix response handler - Githubissues

oauthjs / express-oauth-server

Complete, compliant and well tested module for implementing an OAuth2 Server/Provider with express in node.js

MIT License

484 stars 384 forks source link

Fix response handler #22

Closed mjsalinger closed 8 years ago

maxtruxa commented 8 years ago

Tests fixed with #33.

mjsalinger commented 8 years ago

Rebased to remove some duplicate commits and incorporate latest changes to master. @maxtruxa, one final review?

maxtruxa commented 8 years ago

@mjsalinger Are we always using 302 to redirect? Even if so, it might be a good idea to support the other redirect codes.

mjsalinger commented 8 years ago

302 is the default used in the oauth2 spec.. Others are allowed, and I think that's a good idea to add support for, but I think that should be a separate PR for a future release.

mjsalinger commented 8 years ago

Added issue #37 to track.