search

obahareth / awesome-mena-conferences-and-meetups

A list of awesome conferences and meetups in the MENA region.
https://awesome-mena-conferences-and-meetups.netlify.com
MIT License
5 stars 10 forks source link

Tailwindcss-dir Setup #19

Closed lumie31 closed 6 years ago

lumie31 commented 6 years ago

This PR attempts to fix issue #16

obahareth commented 6 years ago

Also @lumie31 I take it this is just adding and setting up the RTL plugin, but I would still have to go and apply it to places where RTL styling is messed up still, right?

lumie31 commented 6 years ago

Hello, @obahareth I seem to have resolved every issue with this PR over here. Is there anything that needs to be done on this PR before it's closed?

And concerning the RTL plugin -- Yes, It should be applied to places where the RTL styling is still messed up.

obahareth commented 6 years ago

Hey @lumie31, you still have changes to a spec file where you commented out a number of tests.

lumie31 commented 6 years ago

Hello @obahareth, so sorry about this. I have uncommented the tests in the spec file. Hope this fixes the issue now. I'm really sorry for making this PR drag.

lumie31 commented 6 years ago

Hello @obahareth, so sorry about this. I have uncommented the tests in the spec file. Hope this fixes the issue now. I'm really sorry for making this PR drag.

I seem to have run into some clutter with git over here and I'm encountering some difficulties. Wanted to know if everything is okay at your end and if this PR can be closed.

obahareth commented 6 years ago

It's completely alright @lumie31, it happens to all of us :). If you'd ever like some help in dealing with Git, I'd be happy to help you out. I personally use GitKraken and it helps me out a lot.

Thanks for your contribution and your continued help in this repo.

lumie31 commented 6 years ago

So glad this has been approved. On to the next one. Would look into what "GitKraken" offers. Thank you so much!