The RTL is not working!

obahareth / notion-rtl

ARCHIVED - A Chrome extension to enable RTL support in https://notion.so

https://chrome.google.com/webstore/detail/notion-rtl/fflggojmgaedcocmholcdicoedgaabib

MIT License

60 stars 8 forks source link

The RTL is not working! #24

Closed manssorr closed 3 years ago

manssorr commented 3 years ago

Today I found that the RTL not working on the Website or Notion Enhancer, Is this only with me>

dragonwocky commented 3 years ago

A temporary solution is described here for the notion-enhancer until this officially updates: https://github.com/notion-enhancer/notion-enhancer/issues/589

(The same could be achieved on the web by using something like Greasemonkey to run the JS posted there.)

obahareth commented 3 years ago

@manssorr What browser are you using? I gave it a try today on Chrome and there seem to be issues with database pages it only works if you open a nested page, I opened #25 for this.

Pages seem to work without issues for me though.

Can you try the public testing pages and let me know if you're still having issues?

Fahme commented 3 years ago

I tested the extension on Firefox too everything seems to work fine.

Double check you're using the store version and if you're still experiencing the issues, can we have a more detailed bug report ?

manssorr commented 3 years ago

I'm using chrome, and never works with me now on subpages or on database pages :(

manssorr commented 3 years ago

A temporary solution is described here for the notion-enhancer until this officially updates: notion-enhancer/notion-enhancer#589

(The same could be achieved on the web by using something like Greasemonkey to run the JS posted there.)

I'm just using this method on notion enhancer and it works fine right now

Fahme commented 3 years ago

I'm using chrome, and never works with me now on subpages or on database pages :(

Can you do the following :

Create new profile on chrome
make sure there are no extensions installed on the new profile
install notion-rtl extension from store
go to https://www.notion.so/obahareth/Notion-RTL-Tests-8bee4db6585343fc8bae93b791edd726

is the content aligned ??

obahareth commented 3 years ago

@Fahme I'm getting a lot of people mentioning this issue on DMs too, I think it's actually just issue #25. Can you check this comment from dragonwocky?

Fahme commented 3 years ago

@Fahme I'm getting a lot of people mentioning this issue on DMs too, I think it's actually just issue #25. Can you check this comment from dragonwocky?

Yes, i know the root cause i've already fixed it, running some tests and i'll push a PR for a review today or tomorrow latest.

SajadJalilian commented 3 years ago

I have the same problem after recent chrome update

Fahme commented 3 years ago

I have the same problem after recent chrome update

we're working on a fix feel free to check #27 to know when it will be merged

Fahme commented 3 years ago

@manssorr we appreciate your help in testing this PR too #27

manssorr commented 3 years ago

@Fahme I'm glad that was helpful, I really didn't do anything. You guys are doing a great effort. Thank you for making our Arabic writing experience easier and more efficient. I really appreciate that.

Fahme commented 3 years ago

@Fahme I'm glad that was helpful, I really didn't do anything. You guys are doing a great effort. Thank you for making our Arabic writing experience easier and more efficient. I really appreciate that.

Thanks for your words, can you help us test the PR updates too ?

manssorr commented 3 years ago

It works like a charm!!