search

obahareth / notion-rtl

ARCHIVED - A Chrome extension to enable RTL support in https://notion.so
https://chrome.google.com/webstore/detail/notion-rtl/fflggojmgaedcocmholcdicoedgaabib
MIT License
60 stars 8 forks source link

Hot fix rtl #27

Closed Fahme closed 3 years ago

Fahme commented 3 years ago

fixes https://github.com/obahareth/notion-rtl/issues/24

Fahme commented 3 years ago

We can still make more improvements to code and clean the comments a bit IMO but let's roll out an update because it's blocking a lot of users from using the extension.

I did test all of the scenarios things are LGTM waiting your call on it @obahareth

obahareth commented 3 years ago

@Fahme Looks good to me and worked on my end, I pubilshed on Chrome store. I am trying to publish on Firefox but it seems the zip file generated by the build script in the repo doesn't work there. Could you help me out with that?

I will migrate later on to webext for building for multiple browsers, see #26.

obahareth commented 3 years ago

Also @Fahme thank you so much for taking care of this, you are amazing!

Fahme commented 3 years ago

@Fahme Looks good to me and worked on my end, I pubilshed on Chrome store. I am trying to publish on Firefox but it seems the zip file generated by the build script in the repo doesn't work there. Could you help me out with that?

I will migrate later on to webext for building for multiple browsers, see #26.

Awesome, i'll push a FireFox build ASAP.

i'm busy with work currently, so i will take some time to check PR's and fix any other issues.

Hacktoberfest is coming though, so i might get my second shirt merging and fixing all of these stuff the upcoming month haha