Execution Deadline is ignoring the `scheduled_at` offset - Githubissues

oban-bg / oban

💎 Robust job processing in Elixir, backed by modern PostgreSQL and SQLite3

https://oban.pro

Apache License 2.0

3.37k stars 313 forks source link

Execution Deadline is ignoring the `scheduled_at` offset #1102

Closed tayjohno closed 5 months ago

tayjohno commented 5 months ago

Environment

ObanPro 1.4.9
PostgreSQL 15
Erlang/OTP 26 [erts-14.2.5] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit] [dtrace]
Elixir 1.16.3 (compiled with Erlang/OTP 26)

Current Behavior

When scheduling a job with a scheduled_at and a deadline, the deadline is getting set relative to now instead of relative to scheduled_at.

Expected Behavior

The docs say the deadline should be relative to scheduled_at.

[...] That also allows the deadline to consider scheduling—a job scheduled to run 1 hour from now with a 1 hour deadline will expire 2 hours in the future. [...]

https://getoban.pro/docs/pro/1.4.9/Oban.Pro.Worker.html#module-job-deadlines

I dove into the code and confirmed that was the intention, there's just a typo.

sorentwo commented 5 months ago

Thanks for the fix, and tracking down the source. It's fixed on main and will be released in v1.4.10 soon.