search

obartra / ssim

🖼🔬 JavaScript Image Comparison
http://obartra.github.io/ssim
MIT License
298 stars 14 forks source link

remove bmp-js dependency #322

Closed jkeys089 closed 2 years ago

jkeys089 commented 2 years ago

This PR removes bmp-js and relies purely on node-canvas for image decoding. As discussed in https://github.com/obartra/ssim/issues/319, bmp-js decodes images as ABGR, but we need RGBA.

Note: a small change to the CI setup was needed to get node-canvas installed/running on a (relatively) modern version of node.

Closes https://github.com/obartra/ssim/issues/319

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.