search

obazl / rules_ocaml

A Bazel Language Support Package for OCaml
https://obazl.github.io/docs_obazl
Apache License 2.0
32 stars 7 forks source link

fix impl_binary depset #50

Closed crackcomm closed 1 year ago

crackcomm commented 1 year ago

Fixes the error:

Error in depset: cannot add an item of type 'File' to a depset of 'NoneType'

I don't exactly understand the intricacies of this rule, maybe this depset should be totally removed?

crackcomm commented 1 year ago

I can see there was some development on the dev branch but I couldn't successfully try this branch, are there any plans to release this work?

mobileink commented 1 year ago

I can see there was some development on the dev branch but I couldn't successfully try this branch, are there any plans to release this work?

Hi! Thanks very much for reporting this. Yes, I'm definitely planning a release, soon. Within a day or two, I hope. In the meantime, filing an issue would probably be better than a PR.

crackcomm commented 1 year ago

I'm excited to see the release and try out Bazel for building my OCaml code. I'm curious if it will be possible to use directives like git_repository or http_archive to build external OCaml packages within the workspace. Currently, I've been using esy to build code from GitHub (like in this example).

I've had issues using opam for tasks that could be solved with new_local_repository or the link-dev feature in esy, so those are my main concerns. Let me know if that will be possible. Thanks again for the rules!

mobileink commented 1 year ago

Looks like it might be a few more days before I can get to this; sorry about that. rules_ocaml is in pretty good shape, but I'm in the middle of some hairy stuff for OCamlCC and I'm afraid if I switch to something else I'll lose my way...

crackcomm commented 1 year ago

I'm happy to wait and when it's released maybe we can figure it out together.

mobileink commented 1 year ago

Well, as usual my time estimates were off by orders of magnitude. Sorry about that. In any case I just pushed a new alpha version of ocamlcc so now its back to rules_ocaml. When I left off a few months ago I was working on improvements in the tooling - tools_opam for smooth opam integration, and tools_obazl for dune conversion and some other stuff. It might be a few weeks before I have another release ready.