search

obble / modui_classic

modui: for wow classic
45 stars 20 forks source link

Cosmetic bug when increasing or decreasing bag size #53

Open Xaero252 opened 4 years ago

Xaero252 commented 4 years ago

When equipping a larger or smaller bag the bag frame doesn't update. RegisterEvent("BAG_CLOSED") and calling the bag skin function again should solve this. Will try and test next chance I get.

obble commented 4 years ago

Yeah this has been a long-standing bug - I think the logic you suggest may already be happening, I need to take a look at it again

Xaero252 commented 4 years ago

I looked through the repo and there is no inclusion of the BAG_CLOSED event anywhere. This event is fired any time a bag is (re)moved; the BAG_OPEN event is fired any time a bag is equipped in a slot. Would need to hook both of these events to get proper cosmetic behavior, I believe. As equipping into an empty slot will not fire BAG_CLOSED but will fire BAG_OPEN and moving bags between slots will not fire BAG_OPEN but will fire BAG_CLOSED. I'm not certain replacing a bag will fire BAG_OPEN, either, though it may - I'd have to test.