search

obelisk79 / OpenTheme

Home of the OpenTheme system for FreeCAD
GNU Lesser General Public License v2.1
36 stars 8 forks source link

Inconsistent representation of some Draft commands #97

Open furgo16 opened 4 months ago

furgo16 commented 4 months ago

image

Starting from the left bottom toolbar, the Working plane setup, Style settings, Construction mode and Layer management commands are surrounded by a frame, although they are (visually, but probably not implemented as such) regular buttons like the rest of the commands on their right.

In addition, the frame for the Construction mode button is higher than the others and does not provide visual feedback of its state (no change when toggled on or off).

OS: Ubuntu Core 22 (ubuntu:GNOME/ubuntu)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.38039 (Git) Snap 1067
Build type: Release
Branch: main
Hash: 7a9fd501c3ea0e259f843dc21f488ef6af43c201
Python 3.10.12, Qt 5.15.10, Coin 4.0.0, Vtk 7.1.1, OCC 7.7.1
Installed mods: 
  * OpenTheme 2024.7.3
  * Curves 0.6.40
  * ezydxf
  * Ondsel-Lens 2024.7.5.01
  * Assembly4 0.50.14
obelisk79 commented 3 months ago

I believe those are implemented as Qt QPushButton widgets and not QToolButton widgets which is why the styling is inconsistent. While I think you have a point with this issue report, I dont know if making these mirror the QToolButton style of the other toolbars is necessarily going to be good for usability as these include text. I'll experiment, but I'm thinking the best course of action would be to just normalize the height of the buttons to be more consistent.

@maxwxyz @kadet1090 do either of you have any opinions regarding how I should approach this?

maxwxyz commented 3 months ago

IMO all the same height if possible, no hard feelings about the styling. Maybe the same height as a button or the tabbar, this should fit all content.

kadet1090 commented 3 months ago

I'm fine with them being QPushButtons but they should respect sizing, padding etc and look uniformly. Same height as tabbar seems good