obenland / the-bootstrap

A responsive WordPress Theme based on Bootstrap, from Twitter.
http://en.wp.obenland.it/the-bootstrap/
GNU General Public License v3.0
110 stars 46 forks source link

Header image - responsiveness #19

Closed flickster closed 12 years ago

flickster commented 12 years ago

With reference to the question posed here - it suddenly reminded me that I added an extra class to my child theme header-image code (in header.php)
<img src="<?php header_image(); ?>" width="<?php echo get_custom_header()->width; ?>" height="<?php echo get_custom_header()->height; ?>" alt="" class="wp-image-" />

as it then allowed the image to expand and contract as usual. In hindsight, this is probably better adjusted using the stylesheet instead?

Thanks :)

obenland commented 12 years ago

Yes, I added the selector in b2197257e0, this is also fixed in 1.7.1 :)

flickster commented 12 years ago

My bad for not spotting the fix! Sorry for the extra hassle. >_<

obenland commented 12 years ago

Now worries. I rather have it this way than potentially having a buggy Theme :)