search

obenland / the-bootstrap

A responsive WordPress Theme based on Bootstrap, from Twitter.
http://en.wp.obenland.it/the-bootstrap/
GNU General Public License v3.0
110 stars 46 forks source link

Image border hiccup #36

Open obenland opened 12 years ago

obenland commented 12 years ago

Pictures get an ugly frame around them. See here:

http://www.ordnungspolitik.ch/2012/10/28/zulassungsstopp-weihnachten-mit-alain-berset/

They didn't get it some time ago:

http://www.ordnungspolitik.ch/2012/08/28/vom-arbeit-geben-und-arbeit-nehmen/

SamRohn commented 11 years ago

not a bug, the ugly frame comes from putting class="thumbnail" in the anchor vs the img

obenland commented 11 years ago

Thanks @SamRohn :) I opened this ticket as a reminder to find out if there is a way to get that border to appear for images that were embedded prior to The Bootstrap 2.0.0. It was a post in the WordPress Support Forum.

flickster commented 11 years ago

Hello!

Being newbie here, but was wondering if it would be possible to find out the rationale for adding the .thumbnail class to the link please?

At the moment, it causes it to behave very oddly (aside from the border issue) - particularly when coupled with alignleft and alignright in the image class; the specificity of margin-left/margin-right from .thumbnail > img takes precedence over .alignleft and .alignright and the image loses its margin alongside text (amongst other things)

I have tested this on a vanilla install and this appears to be the result in Firefox/Chrome (on Windows XP) ahrefclass

Many thanks in advance! Any suggestions or advice would be appreciated :)

SamRohn commented 11 years ago

to fix the odd border display etc, use class="thumbnail" in the img tag like this

<a href="#"> <img src="#" class="thumbnail"></a>

NOT in the anchor tag like this

<a href="#" class="thumbnail"> <img src="#"></a>

sam

flickster commented 11 years ago

@SamRohn Thanks for the suggestion. It does make sense for the image class to be 'thumbnail' and not the link in a way.

Does this mean that this filter will need to be amended? the_bootstrap_image_send_to_editor from https://github.com/obenland/the-bootstrap/blob/master/functions.php#L1027

I have disabled it for now in the child theme functions using: function exp_remove_addthumbnail() { remove_filter('image_send_to_editor','the_bootstrap_image_send_to_editor'); } add_action( 'after_setup_theme', 'exp_remove_addthumbnail' );