ober / sgpass

SuperGenPass for Emacs
1 stars 1 forks source link

Inconsistent "-pkg.el" file #1

Open purcell opened 11 years ago

purcell commented 11 years ago

Hi! I noticed supergenpass.el on Marmalade, and I'm adding a MELPA recipe for it too.

Note that MELPA can't use your "sgpass-pkg.el", because the package name contained in it is incorrect: it should be "supergenpass", not "sgpass". The package name should match the feature provided by the code. Accordingly, the sgpass-pkg.el file should be renamed to supergenpass-pkg.el.

But note that, in any case, since this is a single-file package, you can just delete the -pkg.el file because neither Marmalade nor MELPA needs it.

Cheers,

-Steve

ober commented 11 years ago

You are referring to just the github repo? Yes I need to remove the extra files. However I just uploaded the single.el

-------- Original message -------- From: Steve Purcell notifications@github.com Date:
To: ober/sgpass sgpass@noreply.github.com Subject: [sgpass] Inconsistent "-pkg.el" file (#1)

Hi! I noticed supergenpass.el on Marmalade, and I'm adding a MELPA recipe for it too.

Note that MELPA can't use your "sgpass-pkg.el", because the package name contained in it is incorrect: it should be "supergenpass", not "sgpass". The package name should match the feature provided by the code. Accordingly, the sgpass-pkg.el file should be renamed to supergenpass-pkg.el.

But note that, in any case, since this is a single-file package, you can just delete the -pkg.el file because neither Marmalade nor MELPA needs it.

Cheers,

-Steve

— Reply to this email directly or view it on GitHub.

purcell commented 11 years ago

Yeah, I was referring to this repo. I figured from Marmalade that you had just uploaded the main .el file. MELPA takes *.el by default, and processes -pkg.el files if it finds them, but in the case of this repo the results would be unexpected.

purcell commented 11 years ago

Handy library, by the way -- thanks for sharing!

ober commented 11 years ago

Ok I will clean this up at lunch. Thanks

-------- Original message -------- From: Steve Purcell notifications@github.com Date:
To: ober/sgpass sgpass@noreply.github.com Cc: Jaime Fournier jaimef@linbsd.org Subject: Re: [sgpass] Inconsistent "-pkg.el" file (#1)

Yeah, I was referring to this repo. I figured from Marmalade that you had just uploaded the main .el file. MELPA takes *.el by default, and processes -pkg.el files if it finds them, but in the case of this repo the results would be unexpected.

— Reply to this email directly or view it on GitHub.

ober commented 11 years ago

I have removed the pkg file. Let me know if anything else is needed for Elpa compat.

Thanks. On Tue, 19 Mar 2013, Steve Purcell wrote:

Date: Tue, 19 Mar 2013 09:39:06 -0700 From: Steve Purcell notifications@github.com Reply-To: ober/sgpass <reply+i-12189518-5cbc474a399c42c69a694e1bb80510d714a8a2f3-169890@reply.gi thub.com> To: ober/sgpass sgpass@noreply.github.com Subject: [sgpass] Inconsistent "-pkg.el" file (#1)

Hi! I noticed supergenpass.el on Marmalade, and I'm adding a MELPA recipe for it too.

Note that MELPA can't use your "sgpass-pkg.el", because the package name contained in it is incorrect: it should be "supergenpass", not "sgpass". The package name should match the feature provided by the code. Accordingly, the sgpass-pkg.el file should be renamed to supergenpass-pkg.el.

But note that, in any case, since this is a single-file package, you can just delete the -pkg.el file because neither Marmalade nor MELPA needs it.

Cheers,

-Steve


Reply to this email directly or view it on GitHub: https://github.com/ober/sgpass/issues/1