ober / winetricks

Automatically exported from code.google.com/p/winetricks
0 stars 0 forks source link

Resume downloads, not abort on checksum failure #383

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Currently any aborted download will restart the next time winetricks is run. 
This is because the logic only checks for a checksum, so it either restarts a 
failed download or skips a download due to a good checksum. It cannot resume 
downloads. The '-c' option to wget in the script is therefore completely 
useless.

A better and KISS approach is to simply download files with a .part extension 
on the disk. If a .part file exists, checksum matching does not occur. This 
would be a trivial amendment to the code for someone who knows the script. I'll 
spend the time getting acquainted and submit a patch if nobody else bothers.

Note: The closest thing that comes close in the code is a check for whether the 
file is greater than 500MB, in which case no checksum matching occurs. However, 
even 5MB is a lot for me, and I'm not even sure what happens if the 500MB is a 
partial download of a 600MB file.

Original issue reported on code.google.com by schivmei...@gmail.com on 28 Nov 2013 at 11:24