oberblastmeister / trashy

a cli system trash manager, alternative to rm and trash-cli
Apache License 2.0
362 stars 13 forks source link

shell completions for fish shell don't complete for paths on `trash` command without `put` #94

Closed m4rch3n1ng closed 1 year ago

m4rch3n1ng commented 1 year ago

pressing <tab> on the trash command only auto-completes for the commands, not the files in the directory. trash put completion works as expected.

i don't know how "clap_complete" works, but you can fix the completion by prepending the line complete -c trash -F to the automatically generated completions.

i only know about fish, but zsh still seems to be broken as of #57.

dropping trash in favor of trash put like suggested in https://github.com/oberblastmeister/trashy/issues/57#issuecomment-1458886458 would obviously work as well, but would be a major breaking change and the loss of a selling point.

nahoj commented 1 year ago

I'm in favor of dropping trash <file> if it helps provide reliable completion, I wrote why here: https://github.com/oberblastmeister/trashy/issues/57#issuecomment-1727298933.

oberblastmeister commented 1 year ago

Closed by #103