oberien / refunct-tas

Tool for Tool assisted Speedruns for the game Refunct
31 stars 8 forks source link

MapEditor: Objects in clusters 24 & 25 are assigned to the wrong clusters. #284

Closed MiningPie closed 11 months ago

MiningPie commented 1 year ago

image pipe is in sky but the one that should be in front of me is what i have selected.

MiningPie commented 1 year ago

Complete list of mislabeled objects: image This pipe rises with cluster 24 but is assigned to cluster 25

image This springpad rises with cluster 24 but is assigned as 25s1

image This springpad rises with cluster 25 but is assigned as 26s1

image This springpad also rises with cluster 25 but is assigned as 24s1

Also posted in #281 as every object affected by that issue is mislabeled.

MiningPie commented 1 year ago

image This line seems to be the one assigning the pipe incorrectly (these are definitely indexed at 0). The pipe should be assigned 23, no

image A few lines below that the springpads should be assigned (from lines 432 -> 435) 23, 24, 24, 26. The assignments here line up with how the springpads are mislabeled.

MiningPie commented 1 year ago

Resolving this issue will very likely resolve #281 as the Z displacement of each object from its correct position perfectly correlates with the difference in InitialZ of the cluster its improperly assigned to and the cluster it rises with.

MiningPie commented 1 year ago

Luke has helped me figure out how to build my own fork of refunct-tas, and I've been able to fix this problem by changing the 4 numbers described above. Changing these also resolves #281 as I predicted.

However, this changes the form of the map files, as the data of one of the springpads stored at 25 was previously stored in cluster 26. This means one of the springpads refuses to be editable, and a crash occurs if you try to press tab and type "26s1" as that element no longer exists.

Previous map file storing a single springpad (specifically springpad 24) in cluster 25 image

Whereas creating a map with the fixed version of refunct-tas stores two springpads in cluster 25 image

These are both the default map as well, some sort of migration system will be necessary.