Open Kogiku opened 4 years ago
Thank you. This is quite an impressive PR! :wink: I will test the changes very soon.
Sorry about all the commit pollution. I probably should have force merged the first commit (still learning).
I think the only other nitpicky thing that might need changing is the version dates in
edit: Not necessary. configure.ac
, NEWS
& README.md
. I'll leave that change to you for when/if you release these changes.
If it helps, I noted all of the changed files in the first comment.
I put 'WIP' in the title because I realized accidentally pushed a non gulp regenerated version. As a result, none of these changes would have taken affect. I decided to fix this by making this theme compile with sassc (another change from Arc).
Oops, you my want to hold off or cancel this pull. By removing the css files, I've removed all changes you and echuber2 made to gtk-dark.css, gtk-light.css, and gtk.css files. All of those changes should have gone in the sass/*.scss files. I will migrate all of those changes, but it might take a while.
Nvm, I didn't see this commit (5f0d457). 😌
Okay, I'm done poking at this theme.
Build changes:
--with-gnome-shell
replaces--with-gnome
sassc
is now a build depend for GTK3 and GNOME Shell--
edit: I lied. I'm still working on it.
I didn't want to spam this PR so I made a separate branch: https://github.com/Kogiku/vertex-theme/tree/port-arc-jnsh-changes
Most of those additional changes come from jnsh's Arc fork: https://github.com/jnsh/arc-theme/
Arc changes for reference and credit: https://github.com/arc-design/arc-theme/compare/20171105...c434a56d2cb5ee49969a62a462db380dee8be62a