oberon-manjaro / vertex-theme

Vertex is a theme for GTK 3, GTK 2, Gnome-Shell and Cinnamon
GNU General Public License v3.0
9 stars 3 forks source link

Remove grey line between navbar and HTML content in Firefox #5

Closed hertz1 closed 4 years ago

hertz1 commented 7 years ago

There's a 1px line between navbar and HTML content that is pretty annoying on sites with a dark background. I don't know the purpose of this line, but I didn't noticed anything weird after removing it. Tested on Vertex, but should be happening on Vertex Dark and Vertex Light too.

With 1px line: screenshot_2017-07-27_14-21-24

Without 1px line: screenshot_2017-07-27_14-22-38

Code to remove it:

#navigator-toolbox:after {
  display: none !important;
}
oberon-manjaro commented 7 years ago

It looks like you are using some other custom theming in your browser that changes the pages' original css. For me youtube does not have a dark background ... it looks like this:

screenshot_2017-07-27_21-10-54

and here's facebook's blue at the top of the page - no bright line here for me either:

screenshot_2017-07-27_21-08-54

hertz1 commented 7 years ago

I'm not using any custom theme, that's the new Youtube layout. You need activate it first in here. Then click on you profile picture and activate the dark theme from the menu.

I'm using Firefox Developer Edition 55, though. Didn't tested on 54 stable.

oberon-manjaro commented 7 years ago

So is this issue only with YouTube's dark theme or do you have another example where you see that line?

hertz1 commented 7 years ago

It happens with others sites too, including manjaro's home page. Tested on 54 stable with a fresh profile and I get the same result. It doesn't happen only with Vertex-Maia-Light userChrome.css.

screenshot_2017-07-27_18-01-57

oberon-manjaro commented 7 years ago

I don't know. I cannot reproduce this:

hp

hertz1 commented 7 years ago

What happens if you add the following code to your userChrome.css?

#navigator-toolbox:after {
  display: none !important;
}

If you don't notice anything weird, why don't apply this rule by default? It'll fix for those who have the issue and for those who don't, they won't even notice the change.

oberon-manjaro commented 7 years ago

Before adding a "bugfix" it is normal procedure to confirm we actually have a reproducible bug that exists not only on one individual system. In this case it looks to me that something in your other config is causing that line. I have at least four installations on two computers here without the issue and sofar I haven't heard of other instance of this problem.

oberon-manjaro commented 7 years ago

Btw when you look at my screenshot of the Facebook header you will see that there isn't just no line but there is a shadow under the address box, while in your YouTube screenshot it is missing!

oberon-manjaro commented 7 years ago

When you look closely you can confirm that in all our screenshots. I think in your case there isn't an extra line but the bottom shadow in your case had the wrong color for whatever reason. Are you sure you are still using an original untouched css file?

hertz1 commented 7 years ago

Yes, I made a symbolic link from /usr/share/themes/Firefox/Vertex-Maia/chrome to my profile folder, so it's using the default css. I'm not home at the moment, but I'll try to investigate this further.