obetame / ColorConvert

sublime text 3 plugin, support RGB2HEX & HEX2RGB and more convert mode.
7 stars 1 forks source link

Settings should be accessible via main menu and command palette #3

Closed braver closed 4 years ago

braver commented 4 years ago

The convention in SublimeText 3 is to have the settings for a package available via Preferences > Package Settings. Additionally, package settings should be available via the command palette. The current implementation via the context menu does not follow that convention. In stead, the context menu should only contain entries applicable to that context. Also, the current implementation fails if the user settings file does not exist yet. The correct way to do this is to provide not the file name (ST will manage that) but the default contents.

This pull requests removes the context menu entry and replaces it with the correct entries in the main menu and command palette.

obetame commented 4 years ago

Thank you for your contribution