obfuscurity / descartes

Introspective dashboard for Graphite
MIT License
502 stars 65 forks source link

Escape all passwords for CGI #117

Closed brntbeer closed 11 years ago

brntbeer commented 11 years ago

if we use password generator, we may get symbols that ruby doesnt like. This fixes it.

obfuscurity commented 11 years ago

Are you sure we want to use CGI#escape (URL encoding)? What sort of characters is it choking on?

obfuscurity commented 11 years ago

Never mind, duh. This should be URL encoded for Graphite. Sorry I'm an idiot.

brntbeer commented 11 years ago

:+1: Thanks!

brntbeer commented 11 years ago

Basically this helps auto-generated PWs and such if you're not paying attention to 1pass and it has "\" or "/" or whatever it was in it. heh